Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbpf has added a member
link
in the structbpf_map_skeleton
, which causes a build failure in SCX. This commit updates the libbpf commit hash to the latest version to avoid this error.Please refer to commit be998aa in libbpf repo.
Error message:
ninja: Entering directory `/home/otteryc/linux2024/scx/build'
[3/25] Compiling C object scheds/c/scx_simple.p/scx_simple.c.o
FAILED: scheds/c/scx_simple.p/scx_simple.c.o
cc -Ischeds/c/scx_simple.p -Ischeds/c -I../scheds/c -I../scheds/include -I../build/libbpf/src/usr/include -I../build/libbpf/include/uapi -fdiagnostics-color=alway
s -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -pthread -MD -MQ scheds/c/scx_simple.p/scx_simple.c.o -MF scheds/c/scx_simple.p/scx_simple.c.o.d -o scheds/c/s
cx_simple.p/scx_simple.c.o -c ../scheds/c/scx_simple.c In file included from ../scheds/c/scx_simple.c:13: scheds/c/scx_simple.p/scx_simple.bpf.skel.h: In function ‘scx_simple__create_skeleton’:
scheds/c/scx_simple.p/scx_simple.bpf.skel.h:243:19: error: ‘struct bpf_map_skeleton’ has no member named ‘link’
243 | s->maps[5].link = &obj->links.simple_ops;
| ^