Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx: Remove unused variables, imports and functions #484

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

vax-r
Copy link
Contributor

@vax-r vax-r commented Aug 9, 2024

Summary

There're several unused variables and functions scattered in scx schedulers now, causing compiling errors or warnings.
The PR is mainly for removal of those unused variables listed below

  • scx_rustland: The member topo_map in Scheduler is never used and thus should be removed, the related imports are removed as well.
  • scx_bpfland: The variable vtime in function task_vtime is never used.

Remove unused variable "vtime" in task_vtime().

Signed-off-by: I Hsin Cheng <[email protected]>
The member "topo_map" in Scheduler is never used and thus should be
removed, the related imports are removed as well.

Signed-off-by: I Hsin Cheng <[email protected]>
@vax-r vax-r changed the title scx_rustland: Remove unused variables and imports scx: Remove unused variables, imports and functions Aug 9, 2024
@vax-r
Copy link
Contributor Author

vax-r commented Aug 13, 2024

@arighi -
I've dropped the commit related to scx_lavd, take a look if you're available, thanks!

@vax-r vax-r requested a review from arighi August 13, 2024 15:07
Copy link
Contributor

@arighi arighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably something is not needed anymore with the latest changes, but we can definitely merge this.

@arighi arighi merged commit 0f018c5 into sched-ext:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants