scx_lavd: revise FlatTopology prettier #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes include 1) chopping down a big function into smaller ones for readability and maintainability and 2) using the interior mutability pattern (Cell and RefCell) to avoid unnecessary clone() calls. There are no functional changes. Signed-off-by: Changwoo Min <[email protected]>
hodgesds
reviewed
Aug 19, 2024
| } | ||
| for (from_k, _) in keys1.iter() { | ||
| for (to_k, to_v) in keys2.iter() { | ||
| for (from_k, from_v) in cpdom_map.iter() { |
There was a problem hiding this comment.
for the nested loops do you think something like itertools::iproduct could be useful?
There was a problem hiding this comment.
Thanks for the suggestion @hodgesds! I will check iproduct.
htejun
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include 1) chopping down a big function into smaller ones for readability and maintainability and 2) using the interior mutability pattern (Cell and RefCell) to avoid unnecessary clone() calls. There are no functional changes.