scx_rusty: Convert to scx_stats #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
htejun
commented
Aug 23, 2024
htejun
commented
- Convert scx_rusty to use scx_stats.
- Some updates to scx_stats in the process.
- scx_layered --monitor behavior updated so that both scx_rusty and scx_layered can behave consistently.
scx_rusty will be converted to scx_stats in a similar fashin with scx_layered. Undo log_recorder conversion in preparation.
This reverts commit 83373b1 in prepration for converting to scx_stats.
to prepare for scx_stats conversion. While at it, make some cosmetic changes.
to prepare for scx_stats conversion.
…delta This will ease transition to scx_stats.
This allows scx_rusty to avoid generating excessive logs for statistics while still allowing detailed monitoring on demand.
OM labels() was called with an array which is then incorrectly interpreted as a single label. Unpack it to list of arguments. While at it, make error reporting a bit more robust.
hodgesds
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.