scx_rustland_core: small core design improvements #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily drop the RL_PREEMPT_CPU flag, we need a better way to implement preemption in scx_rustland_core and it's not very effective at the moment, so simply it drop it for now (it'll be re-added later in the future in a proper way). This change does not affect any scheduler, since RL_PREEMPT_CPU is currently unused. Signed-off-by: Andrea Righi <[email protected]>
Introduce a vtime attribute to struct DispatchedTask that can be set by the user-space scheduler and it'll be use by the BPF component to dispatch the task via scx_bpf_dispatch_vtime(). In this way a user-space scheduler can decide to apply its own internal task ordering or rely on the BPF vtime priority DSQs (or both). Signed-off-by: Andrea Righi <[email protected]>
Refactor the code design to make it more suitable as a template for implementing advanced scheduling policies. In particular, create separate loops for task consumption and task dispatching. This will make the scheduler easier to adapt as a foundation for implementing more complex scheduling policies. Signed-off-by: Andrea Righi <[email protected]>
Include the FIFO example directly in the README.md, instead of linking scx_rlfifo. Including the example directly in the README can be more useful and practical in those cases where internet access is not available or when we need to distribute a more "standalone" documentation. Signed-off-by: Andrea Righi <[email protected]>
htejun
approved these changes
Aug 26, 2024
|
CI is failing for unrelated reasons (maybe systems on github are a bit busy?). Merging for now, instead of restarting the failed CI jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small design improvements, mostly focused at enhancing
scx_rustland_coreusability.API changes:
RL_PREEMPT_CPU(preemption will be re-added later with a better design)DispatchedTask(the vtime will be passed toscx_bpf_dispatched_vtime())Misc Improvements:
scx_rlfifo: refactoring to make the code more suitable to be used as a generic templateREADME.mdofscx_rustland_core(in this way the README can be used standalone as a guide on how to implement schedulers usingscx_rustland_core)