scx_lavd: misc updates (verifier, README, monitor option name, and micro-optimization) #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task is performance-critical, pick_idle_cpu() checks if the previous core is a big core or not. If not, don't try to run on previous core since a performance-critical task is better to run on a big core. Signed-off-by: Changwoo Min <[email protected]>
htejun
reviewed
Sep 2, 2024
scheds/rust/scx_lavd/src/main.rs
Outdated
| @@ -125,7 +125,7 @@ struct Opts { | |||
| /// Run in monitoring mode. Show the specified number of scheduling | |||
| /// samples every second. | |||
| #[clap(long)] | |||
| monitor_sched_samples: Option<u64>, | |||
| monitor: Option<u64>, | |||
There was a problem hiding this comment.
What lavd prints out is a bit different from stats printed out by other schedulers and the parameter's meaning is also different (number of samples instead of interval). Maybe it'd be useful to add more traditional statistics to lavd too which can then use the --stats and --monitor option rather than renaming sampling to take up the name.
There was a problem hiding this comment.
That makes sense. I will drop the relevant commit and will introduce "--monitor" option in the other PR.
htejun
approved these changes
Sep 2, 2024
added 2 commits
September 2, 2024 18:00
Signed-off-by: Changwoo Min <[email protected]>
An old BPF verifier does not allow calling bpf_cpumask_set_cpu() in the BPF syscall context, so we defer actual bpf_cpumask_set_cpu() to the timer handler, update_sys_stat(), to workaround the problem. Signed-off-by: Changwoo Min <[email protected]>
multics69
force-pushed
the
lavd-turbo-tuning2
branch
from
0e6401c
to
0108b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following misc updates: