scx_bpfland: Remove the usage of cast_mask in bpfland_enqueue #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arighi
requested changes
Sep 20, 2024
The usage of cast_mask() within bpfland_enqueue aims to cast the type of "p->cpus_ptr" from "struct bpf_cpumask *" to "const struct cpumask *". However, the type of "p->cpus_ptr" is already "const cpumask_t *" aka "const struct cpumask *", so no conversion is needed. Passing a value of type "struct cpumask *" into "struct bpf_cpumask *" also leads to compiling error. Signed-off-by: I Hsin Cheng <[email protected]>
vax-r
changed the title
|
@arighi - |
arighi
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The usage of
cast_mask()withinbpfland_enqueueaims to cast the type of "p->cpus_ptr" from "struct bpf_cpumask *" to "const struct cpumask *". However, the type of "p->cpus_ptr" is already "const cpumask_t *" aka "const struct cpumask *", so no conversion is needed.Moreover, passing a value of type "struct cpumask *" into "struct bpf_cpumask *" leads to compiling error.