scx_layered: Add per layer time slices to stats #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quoting issue sched-ext#720 description from @hodgesds: > In `scx_layered` the time slice can be [configured per layer](https://github.com/sched-ext/scx/blob/main/scheds/rust/scx_layered/src/main.rs#L493). > This should be added to the > [`LayerStats`](https://github.com/sched-ext/scx/blob/main/scheds/rust/scx_layered/src/stats.rs#L51) > for each layer. During stats > [refresh](https://github.com/sched-ext/scx/blob/main/scheds/rust/scx_layered/src/main.rs#L852) > read the time slice duration (from the bpf skel) to the layer and add it > to the stats. Finally, update the > [format](https://github.com/sched-ext/scx/blob/main/scheds/rust/scx_layered/src/stats.rs#L218) > method for `LayerStats` to print the per layer time slices. Signed-off-by: Ming Yang <[email protected]>
|
example monitoring result:
###### Thu, 3 Oct 2024 20:39:32 -0700 ######
tot= 196 local=87.24 open_idle=21.94 affn_viol= 0.00 proc=7ms
busy= 1.3 util= 7.4 load= 4.3 fallback_cpu= 2
excl_coll=0.00 excl_preempt=0.00 excl_idle=0.00 excl_wakeup=0.00
batch : util/frac= 0.0/ 0.0 load/frac= 0.0/ 0.0 tasks= 13
tot= 0 local= 0.00 wake/exp/reenq= 0.00/ 0.00/ 0.00
xlayer_wake= 0.00 xlayer_rewake= 0.00
keep/max/busy= 0.00/ 0.00/ 0.00 kick= 0.00 yield/ign= 0.00/ 0
open_idle= 0.00 mig= 0.00 xnuma_mig= 0.00 xllc_mig= 0.00 affn_viol= 0.00
preempt/first/xllc/xnuma/idle/fail= 0.00/ 0.00/ 0.00/ 0.00/ 0.00/ 0.00 min_exec= 0.00/ 0.00ms, slice=20ms
cpus= 1 [ 1, 1] 00000001
immediate: util/frac= 0.0/ 0.0 load/frac= 0.0/ 0.0 tasks= 0
tot= 0 local= 0.00 wake/exp/reenq= 0.00/ 0.00/ 0.00
xlayer_wake= 0.00 xlayer_rewake= 0.00
keep/max/busy= 0.00/ 0.00/ 0.00 kick= 0.00 yield/ign= 0.00/ 0
open_idle= 0.00 mig= 0.00 xnuma_mig= 0.00 xllc_mig= 0.00 affn_viol= 0.00
preempt/first/xllc/xnuma/idle/fail= 0.00/ 0.00/ 0.00/ 0.00/ 0.00/ 0.00 min_exec= 0.00/ 0.00ms, slice=20ms
cpus= 2 [ 2, 2] 0000000c
excl_coll= 0.00 excl_preempt= 0.00
normal : util/frac= 7.4/100.0 load/frac= 4.3/100.0 tasks= 49
tot= 196 local=87.24 wake/exp/reenq=12.24/ 0.51/ 0.00
xlayer_wake= 0.00 xlayer_rewake= 0.00
keep/max/busy= 0.51/ 0.00/ 0.00 kick= 0.51 yield/ign= 5.61/ 0
open_idle=21.94 mig=23.98 xnuma_mig= 0.00 xllc_mig= 0.00 affn_viol= 0.00
preempt/first/xllc/xnuma/idle/fail= 0.00/ 0.00/ 0.00/ 0.00/ 0.00/ 0.00 min_exec=87.24/ 27.99ms, slice=20ms
cpus= 1 [ 1, 1] 00000002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically addressing issue #720, described from @hodgesds: