Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_lavd: misc performance tuning #822

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

multics69
Copy link
Contributor

This PR contains the following two performance tunings:

  • give more penalty to long-running tasks
  • direct dispatch when there is an idle CPU

With these two commits, now scx_lavd show more stable performance on osu! with heavy background workloads.

@multics69 multics69 marked this pull request as draft October 21, 2024 03:56
@multics69 multics69 force-pushed the lavd-tuning-v3 branch 2 times, most recently from c1ae83c to 3f5abc1 Compare October 21, 2024 06:25
@multics69 multics69 marked this pull request as ready for review October 21, 2024 06:42
Changwoo Min added 3 commits October 21, 2024 15:56
Giving more penalties to a long-running tasks helps to segregate
latency-critical tasks, which are usually short-running, to
long-running tasks, which are compute-intensive.

Signed-off-by: Changwoo Min <[email protected]>
When there is an idle CPU, direct dispatch is performed to reduce
scheduling latency. This didn't work well before, but it seems
to work well now with other tunings.

Signed-off-by: Changwoo Min <[email protected]>
When a task holds a lock, refill its time slice once at the
ops.dispatch() path to avoid the lock holder preemption problem.

Signed-off-by: Changwoo Min <[email protected]>
@1Naim
Copy link
Contributor

1Naim commented Oct 21, 2024

This definitely shows an improvement on my system compared to main.

Tested-by: Eric Naim <[email protected]>

@multics69 multics69 requested a review from htejun October 21, 2024 10:36
@multics69 multics69 added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 22, 2024
@multics69 multics69 merged commit d5b8aaf into sched-ext:main Oct 22, 2024
21 checks passed
@multics69 multics69 deleted the lavd-tuning-v3 branch October 22, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants