scx_bpfland: minor cleanups #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalute the amount of voluntary context switches directly in the BPF code, without relying on the kernel p->nvcsw metric. Signed-off-by: Andrea Righi <[email protected]>
Get rid of the static MAX_LATENCY_WEIGHT and always rely on the value specified by --nvcsw-max-thresh. This allows to tune the maximum latency weight when running in lowlatency mode (via --nvcsw-max-thresh) and it also restores the maximum nvcsw limit in non-lowlatency mode, that was incorrectly changed during the lowlatency refactoring. Fixes: 4d68133 ("scx_bpfland: rework lowlatency mode to adjust tasks priority") Signed-off-by: Andrea Righi <[email protected]>
The dynamic nvcsw threshold is not used anymore in the scheduler and it doesn't make sense to report it in the scheduler's statistics, so let's just drop it. Signed-off-by: Andrea Righi <[email protected]>
htejun
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing significant, just minor cleanups / restyling and a small fix to restore the old max nvcsw limit that was incorrectly changed during the lowlatency mode refactoring.