Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging staging-app2 in to master. #1213

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Merging staging-app2 in to master. #1213

merged 5 commits into from
Jun 21, 2024

Conversation

ushankar208
Copy link
Contributor

For code author

What does this PR do?

Why do we want to do that?

What are the high level changes?

What other information should the reviewer be aware of when looking at this code?

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ushankar208
You can assign the PR to them by writing /assign @ushankar208 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soSkumar
To complete the pull request process, please assign ushankar208
You can assign the PR to them by writing /assign @ushankar208 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oh-rahulsingla, so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neetuoncehub, oh-rahulsingla, SO-ashusrivastava, so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SO-ashusrivastava,vinaykumar01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neetuoncehub, oh-rahulsingla, SO-ashusrivastava, so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SO-ashusrivastava,vinaykumar01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, neetuoncehub, oh-rahulsingla, raghavaggarwalOH, sampada-ojha, SO-ashusrivastava, so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SO-ashusrivastava,vinaykumar01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, neetuoncehub, oh-rahulsingla, raghavaggarwalOH, sampada-ojha, SO-ashusrivastava, SO-jagjeetsingh, so-kushal, soSkumar, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SO-ashusrivastava,vinaykumar01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oh-integrations
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, neetuoncehub, oh-rahulsingla, raghavaggarwalOH, sampada-ojha, SO-ashusrivastava, SO-jagjeetsingh, so-kushal, soSkumar, vaibhavso, vinaykumar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SO-ashusrivastava,vaibhavso,vinaykumar01]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ushankar208
Copy link
Contributor Author

/hold cancel
/approve

@OhTanishJain OhTanishJain merged commit da3d3e9 into master Jun 21, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neetuoncehub neetuoncehub neetuoncehub approved these changes

@sampada-ojha sampada-ojha sampada-ojha approved these changes

@oh-rahulsingla oh-rahulsingla oh-rahulsingla approved these changes

@raghavaggarwalOH raghavaggarwalOH raghavaggarwalOH approved these changes

@ApoorvaSrivastava ApoorvaSrivastava ApoorvaSrivastava approved these changes

@vaibhavso vaibhavso vaibhavso approved these changes

@bharatsinghoh bharatsinghoh bharatsinghoh approved these changes

@so-kushal so-kushal so-kushal approved these changes

@SO-jagjeetsingh SO-jagjeetsingh SO-jagjeetsingh approved these changes

@SO-ashusrivastava SO-ashusrivastava SO-ashusrivastava approved these changes

@vinaykumar01 vinaykumar01 vinaykumar01 approved these changes

@soSkumar soSkumar soSkumar approved these changes

Assignees
No one assigned
Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.