Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually setting comment on pubkey before export fails #7

Closed
scheibling opened this issue Jun 28, 2022 · 0 comments
Closed

Manually setting comment on pubkey before export fails #7

scheibling opened this issue Jun 28, 2022 · 0 comments
Assignees
@scheibling

Comments

@scheibling
Copy link
Collaborator

When trying to set ca_pubkey.comment to string after init there is no conversion encoding to bytes
Function concat_str_bytes(out=bytes, enc=utf8)?

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File ".....\models.py", line 52, in configure_ssh_client
    f'@cert-authority {ca_pubkey.to_string()}',
  File ".....\site-packages\sshkey_tools\keys.py", line 252, in to_string
    public_bytes += b" " + self.comment
TypeError: can't concat str to bytes
@scheibling scheibling self-assigned this Jun 29, 2022
scheibling added a commit that referenced this issue Jun 29, 2022
@scheibling
Merge pull request #9 from scheibling:scheibling/issue7
4f41b20 
Fixed #7: Added functionality to ensure string/bytestring typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheibling scheibling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scheibling