Bugfixes, testing and linting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
scheibling
commented
Jun 1, 2022
scheibling
commented
- Pylint with HTML report
- Added tests
- can_sign exceptions modified
- Deprecates 3.6-compatibility
Formatted with black
Removed encoding in from_file reading bytes Removed key size option for DSA (ssh only supports 1024bits) Lowered range for random value tests for inflation/deflation
Added fingerprint method to privkey class Added signature verification to pubkey classes Minor corrections
Added ecdsa nonce information Additional checks on validity of data before encoding Minor corrections
Now possible to send timestamp integer to TimeFields Migrated SeparatedListField to KeyValueField Added separate BytestringField for better structured encoding/decoding Added more field and certificate tests No longer possible to instantiate SSHCertificate directly
Cleanup temp files Modified CI linting and testing
Correction to array merge and isinstance checks for 3.7+-compatibility Changed linting version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.