Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new VIA and REALTIME capabilities #210

Closed
wants to merge 2 commits into from
Closed

Add new VIA and REALTIME capabilities #210

wants to merge 2 commits into from

Conversation

ialokim
Copy link
Contributor

@ialokim ialokim commented Jul 27, 2018

This PR adds three new capabilities for network providers:

  • VIA for providers that allow specifying a location to pass by
  • DEPARTURES_REALTIME for providers that support real-time data on departures
  • TRIPS_REALTIME for providers that support real-time data on trip queries.

As discussed in #95, the new capabilities are split into different commits.

Fixes #95.

@schildbach schildbach force-pushed the master branch 2 times, most recently from 63d8043 to 2e5f16d Compare November 5, 2018 18:58
@schildbach schildbach force-pushed the master branch 3 times, most recently from b017ce1 to 28dd2c8 Compare November 17, 2018 13:01
@ialokim
Copy link
Contributor Author

ialokim commented Feb 6, 2019

@schildbach: Would be cool to include this in PTE. Do you have any comments? I would rebase the PR if you are willing to look into it.

@schildbach
Copy link
Owner

VIA would be nice to have, yes. Shouldn't it be named TRIPS_VIA though, as it's a sub-capability of TRIPS?

@ialokim
Copy link
Contributor Author

ialokim commented Feb 8, 2019

Shouldn't it be named TRIPS_VIA?

Good point, I will change that. What are your points against the REALTIME capabilities?

@grote
Copy link
Contributor

grote commented Feb 8, 2019

For Transportr, only TRIPS_REALTIME would be interesting.

@ialokim
Copy link
Contributor Author

ialokim commented Feb 9, 2019

I've rebased onto current master and changed VIA to TRIPS_VIA. Would be great if you could check it out @schildbach.

@schildbach
Copy link
Owner

@ialokim A provider-scoped realtime indicator feels redundant to me. Most providers indicate realtime by providing prognosed/predicted arrival and departure times. If I remember right, some indicate realtime on a per-line basis too (we don't expose that via API yet).

The usecase that was depicted in #95 by @grote could perhaps better be suited by adding a Trip.hasRealtime() which goes through all the stops and returns true if any of the predicted fields are set.

@ialokim
Copy link
Contributor Author

ialokim commented Feb 10, 2019

The usecase that was depicted in #95 by @grote could perhaps better be suited by adding a Trip.hasRealtime() which goes through all the stops and returns true if any of the predicted fields are set.

I agree, that could be another solution, but I'm not sure what would happen in the case a provider does not have real-time information when querying for the first time, but later does have it (I've seen this case quite frequently in my region e.g. if a bus hasn't registered into the system before starting its journey). Trip.hasRealtime() would then return false and Transportr would hide the refresh functionality even if the provider could provide real-time data later.

On the contrary, no provider based on Navitia provides real-time data, so in these cases it would make sense to hide a refresh functionality for the whole provider.

@ialokim
Copy link
Contributor Author

ialokim commented Dec 7, 2019

@schildbach Any more thoughts on this?

@ialokim
Copy link
Contributor Author

ialokim commented Sep 13, 2020

Closed in favor of #333.

@ialokim ialokim closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Capability: VIA and REALTIME
3 participants