-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new VIA and REALTIME capabilities #210
Conversation
63d8043
to
2e5f16d
Compare
b017ce1
to
28dd2c8
Compare
@schildbach: Would be cool to include this in PTE. Do you have any comments? I would rebase the PR if you are willing to look into it. |
|
Good point, I will change that. What are your points against the |
For Transportr, only |
I've rebased onto current master and changed |
@ialokim A provider-scoped realtime indicator feels redundant to me. Most providers indicate realtime by providing prognosed/predicted arrival and departure times. If I remember right, some indicate realtime on a per-line basis too (we don't expose that via API yet). The usecase that was depicted in #95 by @grote could perhaps better be suited by adding a |
I agree, that could be another solution, but I'm not sure what would happen in the case a provider does not have real-time information when querying for the first time, but later does have it (I've seen this case quite frequently in my region e.g. if a bus hasn't registered into the system before starting its journey). On the contrary, no provider based on Navitia provides real-time data, so in these cases it would make sense to hide a refresh functionality for the whole provider. |
@schildbach Any more thoughts on this? |
Closed in favor of #333. |
This PR adds three new capabilities for network providers:
VIA
for providers that allow specifying a location to pass byDEPARTURES_REALTIME
for providers that support real-time data on departuresTRIPS_REALTIME
for providers that support real-time data on trip queries.As discussed in #95, the new capabilities are split into different commits.
Fixes #95.