Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#115 Depricated FlattenException #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smatejic
Copy link

I replaced Deprecated FlattenException with suggested one

@schmittjoh
Copy link
Owner

Can we copy the exception to this bundle instead?

@smatejic
Copy link
Author

http://symfony.com/doc/current/components/debug/introduction.html

The Debug component was introduced in Symfony 2.3. Previously, the classes were located in the HttpKernel component.

Can you please explain what do you mean.

@schmittjoh
Copy link
Owner

I was thinking about copying the code of the class here under a different class name, but since this is a new component, I think we could add a dependency on the component and then just use the new class name.

Can you update the composer.json file to include the component as a dependency?

@smatejic
Copy link
Author

Sure i can add it . Making it as dependency of composer is easier and cleaner .

@smatejic
Copy link
Author

OK after checking if we should add it to composer i discovered it is already there and it is installed as a sub dependency of dependency that is included in composer.

Please take a look at composer.lock line 763 there should be
"name": "symfony/debug",
"version": "2.8.x-dev"

I think this means it is already included :)

@schmittjoh
Copy link
Owner

That is true for Symfony >= 2.3, but not the older versions, which this bundle is still compatible with. So, we just need to add it so that Symfony < 2.3 can still use this bundle.

@GuilhemN GuilhemN mentioned this pull request Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants