Symfony 5.0 compatibility #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated routing depreciation
fixed return type for symfony 5 compatibility
zolex
reviewed
Dec 16, 2020
| @@ -34,4 +34,4 @@ public function getJob() | |||
| { | |||
| return $this->job; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
can you fix this so the tests will pass?
update dependencies
ghost
closed this by deleting the head repository
|
Why was this closed? Why was this closed by user @ghost (GH account for deleted users), when its created by @coderiekelt which is still around? |
|
I've updated my own fork for Symfony 5.4: https://github.com/fnagel/JMSJobQueueBundle |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes compatibility with Symfony 5.0, however I do suspect that it will break backwards compatibility with Symfony 3.
Review would be appreciated, and any changes to be made for this to be merged are welcome.