Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot guess property of type array<subType> #199

Closed
michelsalib opened this issue Oct 15, 2012 · 5 comments
Closed

Cannot guess property of type array<subType> #199

michelsalib opened this issue Oct 15, 2012 · 5 comments

Comments

@michelsalib
Copy link

See the discussion here : c263aba#commitcomment-1996754

It seems that the commit broke the ability of the serializer to guess correct type when property is an array of sub object.

To add more insight, it happened to me when the property is a PersistenCollection of doctrine entity.

@stof
Copy link
Contributor

stof commented Oct 15, 2012

@schmittjohshould the ArrayCollection handler become a CollectionHandler to match based on the Collection interface instead ?

@schmittjoh
Copy link
Owner

Not sure whether we should make this the default for all collections, but we should handle the built-in collections at least.

@schmittjoh
Copy link
Owner

Can you check whether it works after my latest commit?

@michelsalib
Copy link
Author

Sure ! I will do it as soon as I cet a computer, in about 4hours.

Michel Salib


De : Johannes
Envoyé : 17/10/2012 10:58
À : schmittjoh/JMSSerializerBundle
Cc : Michel Salib
Objet : Re: [JMSSerializerBundle] Cannot guess property of type array (#199)

Can you check whether it works after my latest commit?


Reply to this email directly or view it on GitHub:
#199 (comment)

@michelsalib
Copy link
Author

After reading this b8d0072 it worked like a charm. Thanks for your help :)

jorns pushed a commit to jorns/JMSSerializerBundle that referenced this issue Aug 11, 2014
fix issue schmittjoh#199: "array" type ignoring DateTime format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants