Added fix for nested element with attribute and value #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Johannes,
First of all: thank you for sharing this beautiful bundle!
I fixed an issue with the hasValue property of the XmlSerializationVisitor. The visitor remembers the use of @XmlValue even when it is already outside the element it applies to. So when trying to create XML like
It fails on the "location" property, saying:
It is a small fix (just reset the $hasValue property to false) for which I've added some tests. The existing tests don't fail with this fix in place.
Could you take a look at this please?