-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if the data implements SerializationHandlerInterface and in that ca #23
check if the data implements SerializationHandlerInterface and in that ca #23
Conversation
Could you move this to the GraphNavigator.php (this avoids code duplication)? Also, it should have a small test. |
ok .. will have a look. |
…t case call it before going through the custom handlers (guess a similar change would need to be made for deserialization)
done |
hmm i fear that with this change deserialization might be broken .. if i read it properly GraphNavigator.php is used in both cases? does $isSerialization tell me inside the accept() method if i am running in serialization or deserialization mode? |
i have merged your changes and fixed the code accordingly .. the tests pass now. |
Are you sure you committed everything? I got some failures here. |
ooppss ... ran the tests so often that i forgot that i had a filter set .. will have a look. |
done |
I've turned this off by default as it is mainly to ease migration, but otherwise merged everything. |
Hmm .. I dont think its mainly for migration. I think this is an important feature in case someone has a wide range of classes that need to be serialized with custom logic that is simply not feasible to do in a single handler and that would otherwise lead to too many custom handlers. but its easy enough to enable for those users, so its all good i guess :) |
Fix DateTimeZone issue when using the DateTime type
check if the data implements SerializationHandlerInterface and in that case call it before going through the custom handlers (guess a similar change would need to be made for deserialization)
addresses #21