Support for changing default policy

[plazmdk]

For use with FOS rest bundle supporting defensive programming not exposing everything in services.

[GuilhemN]

👎 a third party bundle can't define which exclusion policy to use by default so this would create bugs.

[goetas]

@GuilhemN can you elaborate a bit more? i was thinking to include schmittjoh/serializer#683 sooner of later...

[GuilhemN]

@goetas if you use a bundle that defines entities and depends on the jms serializer, it won't know the default policy and its entities won't be serialized as expected.
At least if you merge this, there should a warning about possible conflicts with third party bundles.

[goetas]

but isn't an user choice the default exclusion strategy?

are you worried that the user decides to use a too strict exclusion strategy that can create unexpected behaviors with other bundles that acts as plugins with the serializer?

[GuilhemN]

@goetas yes, that's it. Moreover these unexpected behaviors won't be easy to catch.

[goetas]

I see your point.

not sure what to do here then 😕 since i see also some advantages in it

[GuilhemN]

Maybe you can allow to configure this for each bundle, or in each file?

[goetas]

currently this is a "per project feature" so can be enabled per any variation of the config.yml in symfony.

or in each file?

if you mean "per entity", this is already possible

per bundle, looks a bit weird.. if you are thinking something as https://symfony.com/doc/current/reference/configuration/assetic.html (per bundle enabler, i find is really weird in this case)

[GuilhemN]

I was thinking about the yaml configuration files, it could be possible to add something on top of it. But I don't know if that's worth it, and if it won't look hacky.

Otherwise, as you proposed, you can configure this at the project level with a proper warning but it looks like a technical debt to me as it might break at any time.

[goetas]

Closing, merging this will lead to unexpected behaviors since will be possible to change defaults at runtime. Third party libraries will not have a consistent default.

thanks @GuilhemN for the hint :)