Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support lazily loaded event listeners and handlers #618

Merged
merged 3 commits into from
Nov 30, 2017

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented Nov 24, 2017

@goetas
Copy link
Collaborator

goetas commented Nov 30, 2017

@xabbuh i've added to your branch the composer dependency on the latest serializer

@xabbuh
Copy link
Contributor Author

xabbuh commented Nov 30, 2017

Thank you @goetas! Tests are green now. Should I bump the branch alias too?

@goetas
Copy link
Collaborator

goetas commented Nov 30, 2017

Currently on this project I'm not using the "properly" the branch alias (you can see that is just 2.x-dev), I guess now should become 2.2-dev, am I right?

What do you thing, Does it make sense to start using it?

@xabbuh
Copy link
Contributor Author

xabbuh commented Nov 30, 2017

I think it makes sense. Makes it easier for users depending on the bundle to use proper version constraints.

@goetas goetas merged commit 59908c2 into schmittjoh:master Nov 30, 2017
@goetas
Copy link
Collaborator

goetas commented Nov 30, 2017

great! thanks! In few hours will release both library and bundle

@xabbuh xabbuh deleted the service-locator branch November 30, 2017 09:48
@xabbuh
Copy link
Contributor Author

xabbuh commented Nov 30, 2017

Thank you so much! This will allow us to make FOSRestBundle compatible with Symfony 4 soon.

xabbuh added a commit to xabbuh/JMSSerializerBundle that referenced this pull request Dec 14, 2017
There was a conflict between schmittjoh#618 and schmittjoh#620 which should be resolved by
this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants