Expect warning instead of notice in PHP 8

schmittjoh · Oct 12, 2020 · 75d8c7b · 75d8c7b
1 parent 6d23e17
commit 75d8c7b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
     "require-dev" : {
         "doctrine/cache" : "^1.0",
         "doctrine/coding-standard": "^8.0",
-        "phpunit/phpunit": "^8.0|^9.0",
+        "phpunit/phpunit": "^8.5|^9.0",
         "psr/container": "^1.0",
         "symfony/cache" : "^3.1|^4.0|^5.0",
         "symfony/dependency-injection" : "^3.1|^4.0|^5.0"

diff --git a/tests/MethodMetadataTest.php b/tests/MethodMetadataTest.php
@@ -6,7 +6,6 @@
 
 use Metadata\MethodMetadata;
 use Metadata\Tests\Fixtures\TestObject;
-use PHPUnit\Framework\Error\Notice;
 use PHPUnit\Framework\TestCase;
 
 class MethodMetadataTest extends TestCase
@@ -85,7 +84,12 @@ public function testReadAccessForUnknownProperty()
     {
         $metadata = new MethodMetadata(TestObject::class, 'setFoo');
 
-        $this->expectException(Notice::class);
+        if (version_compare(PHP_VERSION, '8.0.0-dev', '>=')) {
+            $this->expectWarning();
+        } else {
+            $this->expectNotice();
+        }
+
         $this->expectExceptionMessage('Undefined property: Metadata\MethodMetadata::$unknownProperty');
 
         $metadata->unknownProperty;