Add recursion to FileLocator #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileLocator uses an array of directories to search for metadata for the given class. It will then loop over this array and try to find exact matches by converting backslashes in the FQCN to dots and appending the extension. Because of this, it will always try to do an exact match. If it cannot find that file, it will continue to the next directory. If you need to add metadata to a lot of classes, this quickly becomes very messy. You need to create a single file for every class you want to support. With this change, it should be easier. You can now add multiple definitions in 1 metadata file. The FileLocator will now loop every FQCN until it finds the top level namespace. Signed-off-by: Ruud Kamphuis <[email protected]>
|
This looks a nice idea.... how will it play with jms/serializer? Diid you have a chance to try it? This looks to me a big change that might require a major version bump |
|
I created this specifically for JMS Serializer and it works great. What kind of tests should I add? |
|
@goetas What do you think about this? |
|
@ruudk Thanks! Do you mind adding some into about this on https://github.com/schmittjoh/serializer/blob/master/doc/configuration.rst#configuring-metadata-locations ? |
ruudk
added a commit
to ruudk/serializer
that referenced
this pull request
Jan 13, 2020
Explains what was implemented in schmittjoh/metadata#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileLocator uses an array of directories to search for metadata for the given class. It will then loop over this array and try to find exact matches by converting backslashes in the FQCN to dots and appending the extension.
Because of this, it will always try to do an exact match. If it cannot find that file, it will continue to the next directory.
If you need to add metadata to a lot of classes, this quickly becomes very messy. You need to create a single file for every class you want to support.
With this change, it should be easier. You can now add multiple definitions in 1 metadata file. The FileLocator will now loop every FQCN until it finds the top level namespace.
Signed-off-by: Ruud Kamphuis [email protected]