deps(composer): Update to PHPUnit 11 & Rector 1.0

composer.json

@@ -44,10 +44,10 @@
         "jackalope/jackalope-doctrine-dbal": "^1.3",
         "ocramius/proxy-manager": "^1.0 || ^2.0",
         "phpbench/phpbench": "^1.0",
-        "phpstan/phpstan": "^1.0.2",
-        "phpunit/phpunit": "^9.0 || ^10.0",
+        "phpstan/phpstan": "^1.10.57",
+        "phpunit/phpunit": "^9.0 || ^10.0 || ^11.0",
         "psr/container": "^1.0 || ^2.0",
-        "rector/rector": "^0.19.0",
+        "rector/rector": "^1.0.0",
         "symfony/dependency-injection": "^5.4 || ^6.0 || ^7.0",
         "symfony/expression-language": "^5.4 || ^6.0 || ^7.0",
         "symfony/filesystem": "^5.4 || ^6.0 || ^7.0",

rector.php

@@ -9,5 +9,5 @@
     $rectorConfig->paths([
         __DIR__ . '/src',
     ]);
-    $rectorConfig->sets([LevelSetList::UP_TO_PHP_74]);
+    $rectorConfig->phpVersion(74);
 };

tests/Deserializer/BaseDeserializationTest.php

@@ -11,13 +11,15 @@
 use JMS\Serializer\Tests\Fixtures\GroupsObject;
 use JMS\Serializer\Tests\Fixtures\Price;
 use JMS\Serializer\Tests\Fixtures\Publisher;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class BaseDeserializationTest extends TestCase
 {
     /**
      * @dataProvider dataTypeCannotBeCasted
      */
+    #[DataProvider('dataTypeCannotBeCasted')]
     public function testDeserializationInvalidDataCausesException($data, string $type): void
     {
         $serializer = SerializerBuilder::create()->build();
@@ -48,6 +50,7 @@ public static function dataTypeCannotBeCasted(): iterable
     /**
      * @dataProvider dataDeserializerGroupExclusion
      */
+    #[DataProvider('dataDeserializerGroupExclusion')]
     public function testDeserializerGroupExclusion(array $data, array $groups, array $expected): void
     {
         $serializer = SerializerBuilder::create()->build();

tests/Exclusion/DisjunctExclusionStrategyTest.php

@@ -25,7 +25,7 @@ public function testShouldSkipClassShortCircuiting()
         $first->expects($this->once())
             ->method('shouldSkipClass')
             ->with($metadata, $context)
-            ->will($this->returnValue(true));
+            ->willReturn(true);
 
         $last->expects($this->never())
             ->method('shouldSkipClass');
@@ -46,12 +46,12 @@ public function testShouldSkipClassDisjunctBehavior()
         $first->expects($this->once())
             ->method('shouldSkipClass')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         $last->expects($this->once())
             ->method('shouldSkipClass')
             ->with($metadata, $context)
-            ->will($this->returnValue(true));
+            ->willReturn(true);
 
         self::assertTrue($strat->shouldSkipClass($metadata, $context));
     }
@@ -69,12 +69,12 @@ public function testShouldSkipClassReturnsFalseIfNoPredicateMatched()
         $first->expects($this->once())
             ->method('shouldSkipClass')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         $last->expects($this->once())
             ->method('shouldSkipClass')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         self::assertFalse($strat->shouldSkipClass($metadata, $context));
     }
@@ -92,7 +92,7 @@ public function testShouldSkipPropertyShortCircuiting()
         $first->expects($this->once())
             ->method('shouldSkipProperty')
             ->with($metadata, $context)
-            ->will($this->returnValue(true));
+            ->willReturn(true);
 
         $last->expects($this->never())
             ->method('shouldSkipProperty');
@@ -113,12 +113,12 @@ public function testShouldSkipPropertyDisjunct()
         $first->expects($this->once())
             ->method('shouldSkipProperty')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         $last->expects($this->once())
             ->method('shouldSkipProperty')
             ->with($metadata, $context)
-            ->will($this->returnValue(true));
+            ->willReturn(true);
 
         self::assertTrue($strat->shouldSkipProperty($metadata, $context));
     }
@@ -136,12 +136,12 @@ public function testShouldSkipPropertyReturnsFalseIfNoPredicateMatches()
         $first->expects($this->once())
             ->method('shouldSkipProperty')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         $last->expects($this->once())
             ->method('shouldSkipProperty')
             ->with($metadata, $context)
-            ->will($this->returnValue(false));
+            ->willReturn(false);
 
         self::assertFalse($strat->shouldSkipProperty($metadata, $context));
     }

tests/Exclusion/GroupsExclusionStrategyTest.php

@@ -7,18 +7,17 @@
 use JMS\Serializer\Exclusion\GroupsExclusionStrategy;
 use JMS\Serializer\Metadata\StaticPropertyMetadata;
 use JMS\Serializer\SerializationContext;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class GroupsExclusionStrategyTest extends TestCase
 {
     /**
-     * @param array $propertyGroups
-     * @param array $groups
-     * @param bool $exclude
-     *
      * @dataProvider getExclusionRules
      */
-    public function testUninitializedContextIsWorking(array $propertyGroups, array $groups, $exclude)
+    #[DataProvider('getExclusionRules')]
+
+    public function testUninitializedContextIsWorking(array $propertyGroups, array $groups, bool $exclude)
     {
         $metadata = new StaticPropertyMetadata('stdClass', 'prop', 'propVal');
         $metadata->groups = $propertyGroups;
@@ -57,6 +56,7 @@ public static function getExclusionRules()
     /**
      * @dataProvider getGroupsFor
      */
+    #[DataProvider('getGroupsFor')]
     public function testGroupsFor(array $groups, array $propsVisited, array $resultingGroups)
     {
         $exclusion = new GroupsExclusionStrategy($groups);

tests/Handler/ArrayCollectionDepthTest.php

@@ -11,6 +11,7 @@
 use JMS\Serializer\SerializationContext;
 use JMS\Serializer\Serializer as JMSSerializer;
 use JMS\Serializer\SerializerBuilder;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class ArrayCollectionDepthTest extends TestCase
@@ -28,6 +29,8 @@ protected function setUp(): void
      *
      * @dataProvider getCollections
      */
+    #[DataProvider('getCollections')]
+
     public function testDepth($collection)
     {
         $context = SerializationContext::create()

tests/Handler/ArrayCollectionHandlerTest.php

@@ -11,13 +11,15 @@
 use JMS\Serializer\Tests\Fixtures\ExclusionStrategy\AlwaysExcludeExclusionStrategy;
 use JMS\Serializer\Visitor\SerializationVisitorInterface;
 use Metadata\MetadataFactoryInterface;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 use PHPUnit\Framework\TestCase;
 
 class ArrayCollectionHandlerTest extends TestCase
 {
     /**
      * @doesNotPerformAssertions
      */
+    #[DoesNotPerformAssertions]
     public function testSerializeArray()
     {
         $handler = new ArrayCollectionHandler();
@@ -36,6 +38,7 @@ public function testSerializeArray()
     /**
      * @doesNotPerformAssertions
      */
+    #[DoesNotPerformAssertions]
     public function testSerializeArraySkipByExclusionStrategy()
     {
         $handler = new ArrayCollectionHandler(false);

tests/Handler/DateHandlerTest.php

@@ -9,6 +9,8 @@
 use JMS\Serializer\SerializationContext;
 use JMS\Serializer\Visitor\DeserializationVisitorInterface;
 use JMS\Serializer\Visitor\SerializationVisitorInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 use PHPUnit\Framework\TestCase;
 
 class DateHandlerTest extends TestCase
@@ -39,11 +41,11 @@ public static function getParams()
     }
 
     /**
-     * @param array $params
-     *
      * @doesNotPerformAssertions
      * @dataProvider getParams
      */
+    #[DataProvider('getParams')]
+    #[DoesNotPerformAssertions]
     public function testSerializeDate(array $params)
     {
         $context = $this->getMockBuilder(SerializationContext::class)->getMock();
@@ -57,12 +59,10 @@ public function testSerializeDate(array $params)
     }
 
     /**
-     * @param string    $dateInterval
-     * @param \DateTime $expected
-     *
      * @dataProvider getDeserializeDateInterval
      */
-    public function testDeserializeDateInterval($dateInterval, $expected)
+    #[DataProvider('getDeserializeDateInterval')]
+    public function testDeserializeDateInterval(string $dateInterval, array $expected)
     {
         $visitor = $this->getMockBuilder(DeserializationVisitorInterface::class)->getMock();
         $visitor->method('visitString')->with('2017-06-18');

tests/Handler/IteratorHandlerTest.php

@@ -11,6 +11,7 @@
 use JMS\Serializer\SerializationContext;
 use JMS\Serializer\Visitor\DeserializationVisitorInterface;
 use JMS\Serializer\Visitor\SerializationVisitorInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 final class IteratorHandlerTest extends TestCase
@@ -40,6 +41,7 @@ public static function iteratorsProvider(): array
     /**
      * @dataProvider iteratorsProvider
      */
+    #[DataProvider('iteratorsProvider')]
     public function testSerialize(\Iterator $iterator): void
     {
         $type = get_class($iterator);

tests/Handler/SymfonyUidHandlerTest.php

@@ -10,6 +10,7 @@
 use JMS\Serializer\Handler\SymfonyUidHandler;
 use JMS\Serializer\SerializerBuilder;
 use JMS\Serializer\SerializerInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Uid\AbstractUid;
 use Symfony\Component\Uid\Ulid;
@@ -46,6 +47,7 @@ public static function dataUid(): \Generator
     /**
      * @dataProvider dataUid
      */
+    #[DataProvider('dataUid')]
     public function testSerializeUidToJson(AbstractUid $uid): void
     {
         self::assertJsonStringEqualsJsonString(
@@ -57,6 +59,7 @@ public function testSerializeUidToJson(AbstractUid $uid): void
     /**
      * @dataProvider dataUid
      */
+    #[DataProvider('dataUid')]
     public function testSerializeUidToXmlWithCData(AbstractUid $uid): void
     {
         self::assertXmlStringEqualsXmlString(
@@ -68,6 +71,7 @@ public function testSerializeUidToXmlWithCData(AbstractUid $uid): void
     /**
      * @dataProvider dataUid
      */
+    #[DataProvider('dataUid')]
     public function testSerializeUidToXmlWithoutCData(AbstractUid $uid): void
     {
         self::assertXmlStringEqualsXmlString(
@@ -117,6 +121,7 @@ public function testSerializeUidRejectsInvalidFormat(): void
     /**
      * @dataProvider dataUid
      */
+    #[DataProvider('dataUid')]
     public function testDeserializeUidFromJson(AbstractUid $uid): void
     {
         self::assertTrue($uid->equals($this->createSerializer()->deserialize(sprintf('"%s"', (string) $uid), \get_class($uid), 'json')));
@@ -125,6 +130,7 @@ public function testDeserializeUidFromJson(AbstractUid $uid): void
     /**
      * @dataProvider dataUid
      */
+    #[DataProvider('dataUid')]
     public function testDeserializeUidFromXml(AbstractUid $uid): void
     {
         self::assertTrue($uid->equals($this->createSerializer()->deserialize(sprintf('<?xml version="1.0" encoding="UTF-8"?><result>%s</result>', (string) $uid), \get_class($uid), 'xml')));

tests/Metadata/ClassMetadataTest.php

@@ -4,8 +4,10 @@
 
 namespace JMS\Serializer\Tests\Metadata;
 
+use JMS\Serializer\Exception\InvalidMetadataException;
 use JMS\Serializer\Metadata\ClassMetadata;
 use JMS\Serializer\Metadata\PropertyMetadata;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class ClassMetadataTest extends TestCase
@@ -23,14 +25,14 @@ public static function getAccessOrderCases()
 
     public function testSerialization()
     {
-        $meta = new PropertyMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder', 'b');
+        $meta = new PropertyMetadata(PropertyMetadataOrder::class, 'b');
         $restoredMeta = unserialize(serialize($meta));
         self::assertEquals($meta, $restoredMeta);
     }
 
     public function testSerializationClass()
     {
-        $meta = new ClassMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder');
+        $meta = new ClassMetadata(PropertyMetadataOrder::class);
         $meta->xmlRootPrefix = 'foo';
         $meta->xmlDiscriminatorCData = true;
         $meta->xmlDiscriminatorAttribute = false;
@@ -43,11 +45,12 @@ public function testSerializationClass()
     /**
      * @dataProvider getAccessOrderCases
      */
+    #[DataProvider('getAccessOrderCases')]
     public function testSetAccessorOrderCustom(array $order, array $expected)
     {
-        $metadata = new ClassMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder');
-        $metadata->addPropertyMetadata(new PropertyMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder', 'b'));
-        $metadata->addPropertyMetadata(new PropertyMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder', 'a'));
+        $metadata = new ClassMetadata(PropertyMetadataOrder::class);
+        $metadata->addPropertyMetadata(new PropertyMetadata(PropertyMetadataOrder::class, 'b'));
+        $metadata->addPropertyMetadata(new PropertyMetadata(PropertyMetadataOrder::class, 'a'));
         self::assertEquals(['b', 'a'], array_keys($metadata->propertyMetadata));
 
         $metadata->setAccessorOrder(ClassMetadata::ACCESSOR_ORDER_CUSTOM, $order);
@@ -56,9 +59,9 @@ public function testSetAccessorOrderCustom(array $order, array $expected)
 
     public function testSetAccessorOrderAlphabetical()
     {
-        $metadata = new ClassMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder');
-        $metadata->addPropertyMetadata(new PropertyMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder', 'b'));
-        $metadata->addPropertyMetadata(new PropertyMetadata('JMS\Serializer\Tests\Metadata\PropertyMetadataOrder', 'a'));
+        $metadata = new ClassMetadata(PropertyMetadataOrder::class);
+        $metadata->addPropertyMetadata(new PropertyMetadata(PropertyMetadataOrder::class, 'b'));
+        $metadata->addPropertyMetadata(new PropertyMetadata(PropertyMetadataOrder::class, 'a'));
         self::assertEquals(['b', 'a'], array_keys($metadata->propertyMetadata));
 
         $metadata->setAccessorOrder(ClassMetadata::ACCESSOR_ORDER_ALPHABETICAL);
@@ -68,6 +71,7 @@ public function testSetAccessorOrderAlphabetical()
     /**
      * @dataProvider providerPublicMethodData
      */
+    #[DataProvider('providerPublicMethodData')]
     public function testAccessorTypePublicMethod($property, $getterInit, $setterInit, $getterName, $setterName)
     {
         $object = new PropertyMetadataPublicMethod();
@@ -82,9 +86,10 @@ public function testAccessorTypePublicMethod($property, $getterInit, $setterInit
     /**
      * @dataProvider providerPublicMethodException
      */
+    #[DataProvider('providerPublicMethodException')]
     public function testAccessorTypePublicMethodException($getter, $setter, $message)
     {
-        $this->expectException('\JMS\Serializer\Exception\InvalidMetadataException');
+        $this->expectException(InvalidMetadataException::class);
         $this->expectExceptionMessage($message);
 
         $object = new PropertyMetadataPublicMethod();

tests/Metadata/Driver/DoctrineDriverTest.php

@@ -174,7 +174,7 @@ protected function getDoctrineDriver()
         $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
         $registry->expects($this->atLeastOnce())
             ->method('getManagerForClass')
-            ->will($this->returnValue($this->getEntityManager()));
+            ->willReturn($this->getEntityManager());
 
         return new DoctrineTypeDriver(
             $this->getMetadataDriver(),