Support value types in serialization

Allows serialization of value types (i.e. `true` and `false`, as opposed to `bool`), including in union types (e.g. `string|false`). Otherwise, tries to create class with FQCN "true" and, for union types, filters out value types as non-primitive. Fixes #1568
schmittjoh · Nov 12, 2024 · 62f7bb4 · 62f7bb4
1 parent a093b21
commit 62f7bb4
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/src/GraphNavigator/SerializationGraphNavigator.php b/src/GraphNavigator/SerializationGraphNavigator.php
@@ -156,6 +156,8 @@ public function accept($data, ?array $type = null)
 
             case 'bool':
             case 'boolean':
+            case 'true':
+            case 'false':
                 return $this->visitor->visitBoolean((bool) $data, $type);
 
             case 'double':

diff --git a/src/Metadata/Driver/TypedPropertiesDriver.php b/src/Metadata/Driver/TypedPropertiesDriver.php
@@ -75,6 +75,8 @@ private function getDefaultWhiteList(): array
             'float',
             'bool',
             'boolean',
+            'true',
+            'false',
             'string',
             'double',
             'iterable',

diff --git a/tests/Fixtures/TypedProperties/UnionTypedProperties.php b/tests/Fixtures/TypedProperties/UnionTypedProperties.php
@@ -10,6 +10,8 @@ class UnionTypedProperties
 
     private int|bool|float|string|null $nullableData;
 
+    private string|false $valueTypedUnion;
+
     public function __construct($data)
     {
         $this->data = $data;

diff --git a/tests/Metadata/Driver/UnionTypedPropertiesDriverTest.php b/tests/Metadata/Driver/UnionTypedPropertiesDriverTest.php
@@ -57,6 +57,31 @@ public function testInferUnionTypesShouldResultInManyTypes()
         );
     }
 
+    public function testInferUnionTypesShouldIncludeValueTypes()
+    {
+        $m = $this->resolve(UnionTypedProperties::class);
+
+        self::assertEquals(
+            [
+                'name' => 'union',
+                'params' =>
+                    [
+                        [
+                            [
+                                'name' => 'string',
+                                'params' => [],
+                            ],
+                            [
+                                'name' => 'false',
+                                'params' => [],
+                            ],
+                        ],
+                    ],
+            ],
+            $m->propertyMetadata['valueTypedUnion']->type,
+        );
+    }
+
     private function resolve(string $classToResolve): ClassMetadata
     {
         $namingStrategy = new IdenticalPropertyNamingStrategy();