Skip to content

Commit

Permalink
FormErrorHandler::serializeFormToXml, FormErrorHandler::serializeForm…
Browse files Browse the repository at this point in the history
…ErrorToXml, ConstraintViolationHandler::serializeListToXml and ConstraintViolationHandler::serializeViolationToXml depend explicitly on XmlSerializationVisitor
  • Loading branch information
goetas committed Nov 8, 2019
1 parent 765b85f commit 95765aa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions src/Handler/ConstraintViolationHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use JMS\Serializer\GraphNavigatorInterface;
use JMS\Serializer\SerializationContext;
use JMS\Serializer\Visitor\SerializationVisitorInterface;
use JMS\Serializer\XmlSerializationVisitor;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationList;

Expand Down Expand Up @@ -35,7 +36,7 @@ public static function getSubscribingMethods()
return $methods;
}

public function serializeListToXml(SerializationVisitorInterface $visitor, ConstraintViolationList $list, array $type): void
public function serializeListToXml(XmlSerializationVisitor $visitor, ConstraintViolationList $list, array $type): void
{
$currentNode = $visitor->getCurrentNode();
if (!$currentNode) {
Expand All @@ -55,7 +56,7 @@ public function serializeListToJson(SerializationVisitorInterface $visitor, Cons
return $visitor->visitArray(iterator_to_array($list), $type);
}

public function serializeViolationToXml(SerializationVisitorInterface $visitor, ConstraintViolation $violation, ?array $type = null): void
public function serializeViolationToXml(XmlSerializationVisitor $visitor, ConstraintViolation $violation, ?array $type = null): void
{
$violationNode = $visitor->getDocument()->createElement('violation');

Expand Down
5 changes: 3 additions & 2 deletions src/Handler/FormErrorHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

use JMS\Serializer\GraphNavigatorInterface;
use JMS\Serializer\Visitor\SerializationVisitorInterface;
use JMS\Serializer\XmlSerializationVisitor;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\FormError;
use Symfony\Component\Translation\TranslatorInterface;
Expand Down Expand Up @@ -54,7 +55,7 @@ public function __construct(?TranslatorInterface $translator = null, string $tra
/**
* @param array $type
*/
public function serializeFormToXml(SerializationVisitorInterface $visitor, Form $form, array $type): \DOMElement
public function serializeFormToXml(XmlSerializationVisitor $visitor, Form $form, array $type): \DOMElement
{
$formNode = $visitor->getDocument()->createElement('form');

Expand Down Expand Up @@ -89,7 +90,7 @@ public function serializeFormToJson(SerializationVisitorInterface $visitor, Form
/**
* @param array $type
*/
public function serializeFormErrorToXml(SerializationVisitorInterface $visitor, FormError $formError, array $type): \DOMCdataSection
public function serializeFormErrorToXml(XmlSerializationVisitor $visitor, FormError $formError, array $type): \DOMCdataSection
{
return $visitor->getDocument()->createCDATASection($this->getErrorMessage($formError));
}
Expand Down

0 comments on commit 95765aa

Please sign in to comment.