Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Removing abandoned hoa from serializer #1182

Closed
vsychov opened this issue Apr 3, 2020 · 5 comments · Fixed by #1212
Closed

[RFC] Removing abandoned hoa from serializer #1182

vsychov opened this issue Apr 3, 2020 · 5 comments · Fixed by #1212

Comments

@vsychov
Copy link

vsychov commented Apr 3, 2020

Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes

Hi guys,

jms serialize use hoa/compiler for parse some data, but looks like hoa project was abandoned since 2018, for now it have problem with php 7.4 opache.preload (hoaproject/Consistency#36, hoaproject/Consistency#35), and nobody react for this. JMS serializer is popular library, that used by lot of peoples in lot of project, but abandoned dependency blocking that projects from migrate to php 7.4, from my side situation looks not very good.

So depends on above, I propose make decision to remove HOA project from dependency, and use something different, or fork HOA project to another repository, merge exists pull request, and forget about problems with php 7.4.

Best regards.

@goetas
Copy link
Collaborator

goetas commented Apr 4, 2020

That sounds something that makes sense.

Is there anybody interested to implement the type definition parsing using doctrine lexer or via regex or with some other library?

sanmai added a commit to sanmai/serializer that referenced this issue Apr 6, 2020
@sanmai sanmai mentioned this issue Apr 6, 2020
1 task
@Jean85
Copy link
Contributor

Jean85 commented Apr 9, 2020

I rapidly scanned the code... I would like to have it too, but wouldn't this change be a BC requiring a new major? Hoa\Visitor\Visit is implemented by \JMS\Serializer\Type\TypeVisitor: https://github.com/schmittjoh/serializer/blob/7d81f6ae961801416aa3a8a3120316b978a8f133

Maybe stopping the usage of this class (but not removing it) is enough to fix the preloading issue?

@Jean85
Copy link
Contributor

Jean85 commented Apr 9, 2020

#1184 seems another possible solution, but it has some BC downstream...

@goetas
Copy link
Collaborator

goetas commented Apr 12, 2020

I think that stopping to use the current TypeVisitor, mark it as deprecated, and start using a new implementation (implemented with "whatever") should be enough

@Jean85
Copy link
Contributor

Jean85 commented Apr 14, 2020

I pushed a draft of my approach with #1186. I'm not sure when I'll have time to work further on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants