internal classes have false in reflection::getFilename() #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure, those are not added to ClassMetadata->fileResources, since otherwise file_exists in strict_mode=1 trips over in the metadata package at https://github.com/schmittjoh/metadata/blob/master/src/ClassMetadata.php#L65
|
Thanks for the PR. This makes sense. Can you add tests? |
|
i have added tests by my self |
|
thanks |
|
@goetas Can this be tagged in a new release? I just upgraded to JMS Serializer 2.0 and spend 1 hour debugging this issue. Already wanted to create a PR for this when I discovered it was already fixed :) |
|
Thanks a lot for this and sorry about the missing tests |
|
2.0.2 released |
|
thanks both of you 👍 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure, internal classes filepaths are not added to ClassMetadata->fileResources, since otherwise file_exists in strict_mode=1 trips over in the metadata package at https://github.com/schmittjoh/metadata/blob/master/src/ClassMetadata.php#L65