Fix for failing doctrine object constructor on embeddable class #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notrix
force-pushed
the
xml-embeddable-fix
branch
from
8fa83f4 to
a074e27
Compare
|
Hi, sorry for the delay. |
|
Changes related to #1075 |
notrix
force-pushed
the
xml-embeddable-fix
branch
2 times, most recently
from
8e588bb to
34acaff
Compare
notrix
force-pushed
the
xml-embeddable-fix
branch
from
34acaff to
0999267
Compare
|
@goetas I have resolved conflicts. |
|
Thank you! |
|
Shouldn't this be cherry-picked in the 1.x branch (if it's still supported - which seems to be the case as the last tag is 2 months old) ? |
|
Can you please send a pull request for that on the 1.x branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual issue is on doctrine/persistence component. I have registered an issue to them https://github.com/doctrine/persistence/issues/37
The case is that doctrine is using XML metadata driver returns isTransient() === false on embeddable class and this class could not be found in database as it has no identifiers.
I have added one additional check to ensure that we have identifier and test that uses different entity manager with XML metadata driver.