-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Twig 2.7 namespaces #1061
use Twig 2.7 namespaces #1061
Conversation
I think there is a problem with Travis-CI config - the test is shown as passed, but it contains errors: https://travis-ci.org/schmittjoh/serializer/jobs/506178733. Although, it's not caused by this PR. |
Hi, Thanks for the PR. Currently I think that is not a good idea to drop Twig 1.x and <2.7 support. C Can this changes be done in a backward compatible way, preferring the new class names if they are available, and falling back on the old if they are not available? |
This doesn't necessarily break compatibility with all versions <2.7. Namespaced aliases existed several versions before that, 2.7 only added the deprecation of non-namespaced types. Btw. not supporting Twig 2.7 is quite a problem now because roave/security-advisories no longer allows Twig 2.0-2.6 because of this vulnerability. |
Until schmittjoh/serializer#1061 gets merged Because there is a compatibility issue with a deprecated twig version
Until schmittjoh/serializer#1061 gets merged Because there is a compatibility issue with a deprecated twig version
Until schmittjoh/serializer#1061 gets merged Because there is a compatibility issue with a deprecated twig version
If the version constraint is set to |
Having |
Thanks! |
Twig 2.7 moved to namespaced classes instead of old pre-PHP5.3 ones.