Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "empty" XML namespace handling #1095

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

discordier
Copy link
Contributor

Q A
Bug fix? yes
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1087
License MIT

This is a basic implementation of xmlns="" handling.

The implementation works for me (see the tests).

@discordier
Copy link
Contributor Author

Fixed code style.

@discordier discordier mentioned this pull request Jun 13, 2019
This is a basic implementation of `xmlns=""` handling.
@discordier
Copy link
Contributor Author

Removed the loop, how shall we approach the feature request of @antonioturdo regarding applying it to collections?

@goetas
Copy link
Collaborator

goetas commented Jun 18, 2019

This looks good to me!

From my understanding, the same approach can be used for serializing/deserializing collections.
discordier or @antonioturdo Let me know if you prefer to continue on it directly in this PR or on a separate one.

@goetas goetas self-requested a review June 18, 2019 05:04
@discordier
Copy link
Contributor Author

As I need the behavior implemented in this PR in a project currently and considering that I have not had a look at the collection part (and I think I won't have the time in the near future), I'd favor merging it rather sooner than later. 😸

@goetas
Copy link
Collaborator

goetas commented Jun 18, 2019

@discordier I agree! @antonioturdo feel free to send a PR for collections support

@goetas goetas merged commit 0e3bb12 into schmittjoh:master Jun 18, 2019
@antonioturdo
Copy link

@discordier I agree! @antonioturdo feel free to send a PR for collections support

Ok, I'll do if I find some time.

@discordier discordier deleted the hotfix/issue-1087 branch June 18, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants