-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "empty" XML namespace handling #1095
Conversation
7ab1eba
to
97c5072
Compare
Fixed code style. |
97c5072
to
c7bce38
Compare
This is a basic implementation of `xmlns=""` handling.
c7bce38
to
99c369c
Compare
Removed the loop, how shall we approach the feature request of @antonioturdo regarding applying it to collections? |
This looks good to me! From my understanding, the same approach can be used for serializing/deserializing collections. |
As I need the behavior implemented in this PR in a project currently and considering that I have not had a look at the collection part (and I think I won't have the time in the near future), I'd favor merging it rather sooner than later. 😸 |
@discordier I agree! @antonioturdo feel free to send a PR for collections support |
Ok, I'll do if I find some time. |
This is a basic implementation of
xmlns=""
handling.The implementation works for me (see the tests).