Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Doctrine 2 immutable datetime types to field mapping. #1104

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Add Doctrine 2 immutable datetime types to field mapping. #1104

merged 2 commits into from
Jul 11, 2019

Conversation

sonnymilton
Copy link
Contributor

Q A
Bug fix? yes
New feature? yes
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT

goetas
goetas reviewed Jul 3, 2019
View reviewed changes
Copy link
Collaborator

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the PR! Looks good.
Can you answer to my question above?

src/Metadata/Driver/AbstractDoctrineTypeDriver.php Outdated Show resolved Hide resolved
@sonnymilton sonnymilton force-pushed the doctrine-immutable-date-metadata branch from ea9a115 to d8ab1ee Compare July 3, 2019 22:08
@sonnymilton
Copy link
Contributor Author

I think it looks cleaner.

@goetas goetas merged commit c0e0607 into schmittjoh:master Jul 11, 2019
@goetas
Copy link
Collaborator

goetas commented Jul 11, 2019

Thanks!

@sonnymilton sonnymilton deleted the doctrine-immutable-date-metadata branch July 16, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas goetas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonnymilton @goetas