Add constants for the formats #1105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kiironoaki
commented
Jul 7, 2019
kiironoaki
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Doc updated | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1079 |
| License | MIT |
goetas
reviewed
Jul 11, 2019
| public const FORMAT_JSON = 'json'; | ||
| public const FORMAT_XML = 'xml'; | ||
|
|
||
| public const FORMATS_SUPPORTED = [ |
There was a problem hiding this comment.
not sure if this is a good idea.
Having this constants in the serializer interface does not allow to add formats (visitors) without changing this interface.
This makes useless the idea of being able to add your own visitors.
goetas
requested changes
Jul 11, 2019
|
AS per motivations in #1105 (comment), closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.