Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPUnit deprecations #1123

Merged
merged 4 commits into from
Sep 14, 2019
Merged

Fix PHPUnit deprecations #1123

merged 4 commits into from
Sep 14, 2019

Conversation

Majkl578
Copy link
Contributor

Q A
Bug fix? yes
Tests pass? yes

@Majkl578 Majkl578 force-pushed the phpunit-deprecations branch from 1d1d573 to 1b1b3f5 Compare September 13, 2019 21:55
@Majkl578
Copy link
Contributor Author

Build failure unrelated.

@goetas goetas merged commit ff89778 into schmittjoh:master Sep 14, 2019
@goetas
Copy link
Collaborator

goetas commented Sep 14, 2019

Thanks @Majkl578 !

I'm always amused to see how much work has PHPUnit generated in the last 5 years! Circling around with adding features and then deprecating them...

@Majkl578 Majkl578 deleted the phpunit-deprecations branch September 14, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Majkl578 @goetas