Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 5.0 compatibility #1145

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Symfony 5.0 compatibility #1145

merged 1 commit into from
Dec 9, 2019

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Dec 7, 2019

Q A
Bug fix? no
New feature? yes
Doc updated no
BC breaks? -
Deprecations? -
Tests pass? yes
Fixed tickets -
License MIT

@Bukashk0zzz
Copy link
Contributor

@goetas Hi, When you plan to merge this PR?

@goetas
Copy link
Collaborator Author

goetas commented Dec 9, 2019

was waiting for someone to review it...

@Bukashk0zzz
Copy link
Contributor

I know that I am not the one who can say for sure that all cool, but as for me all looks right.

I tested this brunch on my Symfony 5 project using composer aliasing:

"jms/serializer": "sf5-dev as 3.3.x-dev",
"jms/serializer-bundle": "^3.5",

All works well. Before these fixes, I get an error about TranslatorInterface when serializing Symfony form.

@goetas goetas merged commit 05fea5a into master Dec 9, 2019
@goetas
Copy link
Collaborator Author

goetas commented Dec 9, 2019

Alright! Thanks for checking

@goetas
Copy link
Collaborator Author

goetas commented Dec 9, 2019

Will create a new tag tomorrow

@Bukashk0zzz
Copy link
Contributor

Thank you.

@goetas goetas deleted the sf5 branch August 3, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goetas @Bukashk0zzz