do not hide Exceptions from custom handlers but correctly handle null #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hikariii
force-pushed
the
customHandlerExceptions
branch
3 times, most recently
from
46ea978 to
693717f
Compare
|
Travis is failing for a reason that does not seem related to this PR: https://travis-ci.org/github/schmittjoh/serializer/jobs/661093321#L318 |
goetas
reviewed
Mar 12, 2020
goetas
reviewed
Mar 12, 2020
|
Thanks for your contribution. This is something that should be fixed. The approach is ok, I've left just few comments on the tests. |
Hikariii
force-pushed
the
customHandlerExceptions
branch
from
693717f to
96e0c6c
Compare
Hikariii
commented
Mar 13, 2020
Hikariii
force-pushed
the
customHandlerExceptions
branch
from
96e0c6c to
887b8d5
Compare
Hikariii
force-pushed
the
customHandlerExceptions
branch
from
887b8d5 to
61eb3d7
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solve the issue of #1168 by catching and handling the specific
NotAcceptableExceptioncase. All other Exceptions are not caught so Exceptions thrown in handlers are visible as requested.