Handle ObjectConstructor returning NULL #1172
Conversation
The DeserializationGraphNavigator calls the construct method on an instance of ObjectConstructorInterface. According to the return type hint of that method, it is allowed to return NULL. However, when this occurs, the navigator will pass NULL to the startVisitingObject method of the visitor. startVisitingObject expects an object to be passed in, thus causing the serializer to crash with a type error. We can prevent this error by calling the `visitNull` method if we detect that the ObjectConstructor has returned NULL instead of an object.
|
Hi, thanks for your contribution. |
|
Thanks for your quick reply! Why do you reckon it shouldn't happen? The DoctrineObjectConstructor explicitly defines a NULL strategy, which seems to have valid use cases. At least it does in the application where I encountered this situation. As it stands now, the NULL strategy is the default strategy, but breaks when encountered at run-time. Are you open to merging this fix, or do you have a suggestion for a different approach to fixing this issue? |
|
I'm interested in merging this, was just hoping there was a better solution 😁 In the next week will test it and if is OK, do the merge |
|
Gotcha, thanks! |
The DeserializationGraphNavigator calls the construct method on an instance of ObjectConstructorInterface. According to the return type hint of that method, it is allowed to return NULL. However, when this occurs, the navigator will pass NULL to the startVisitingObject method
of the visitor. startVisitingObject expects an object to be passed in, thus causing the serializer to crash with a type error.
We can prevent this error by calling the
visitNullmethod if we detect that the ObjectConstructor has returned NULL instead of an object.