Fix Support conditional exclude for classes #1187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1099 support for ExcludeIf on class level was added, unfortunately the condition was inverted.
Current behavior would actually exclude this class:
However it should only exclude the class if the condition evaluates to true:
This was due to a copy mistake from Expose, which internal also uses Exclude, but with the condition negated and also due to a test scenario which was not very clear to udnerstand.
I have simplified the test to make it more clear and fixed the drivers.