added support for milliseconds in DateInterval deserialization #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoba
force-pushed
the
fix-DateInterval-milliseconds
branch
3 times, most recently
from
5e1c7ae to
586f568
Compare
goetas
requested changes
Jul 11, 2020
src/Handler/DateHandler.php
Outdated
| $dateInterval = new \DateInterval($data); | ||
| // milliseconds are only available from >=7.1 |
There was a problem hiding this comment.
This library requires at least php 7.2, so there is no need to check it
tests/Handler/DateHandlerTest.php
Outdated
| $visitor->method('visitString')->with('2017-06-18'); | ||
|
|
||
| $element = new \SimpleXMLElement('<DateInterval>' . $dateInterval . '</DateInterval>'); | ||
| $deserialized = $this->handler->deserializeDateIntervalFromXml($visitor, $element, [], $context); |
There was a problem hiding this comment.
You can test the json version instead, so no need to deal with simplexml
ivoba
force-pushed
the
fix-DateInterval-milliseconds
branch
from
586f568 to
ef8c948
Compare
|
@goetas Adjusted the PR with the changes requested. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically the same as this: goetas-webservices/xsd2php-runtime#14