Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove missing deprecated removal on hasData #1245

Merged

Conversation

rflavien
Copy link
Contributor

@rflavien rflavien commented Aug 20, 2020

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT

This deprecated code was not removed as planned. If it still deprecated it has to be updated to release 4.0.
Curently there is no alternative for hasData, so I choose to remove the deprecated annotation.

@goetas
Copy link
Collaborator

goetas commented Aug 22, 2020

👍

@goetas goetas merged commit 9685e94 into schmittjoh:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants