Allow interfaces for typed properties #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilake-v
reviewed
Oct 26, 2020
| @@ -1356,6 +1356,10 @@ public function testTypedProperties() | |||
| $this->markTestSkipped(sprintf('%s requires PHP 7.4', __METHOD__)); | |||
| } | |||
|
|
|||
| $builder = SerializerBuilder::create($this->handlerRegistry, $this->dispatcher); | |||
There was a problem hiding this comment.
@marein Hi,
nice idea, and thanks for pull-request ! 👍
Are there any things to consider during Deserialization process, no changes there?
Would be possible to have a Deserialization test, maybe ? :)
Thanks!
There was a problem hiding this comment.
Hi @slava-v, thank you. The deserialization process is covered here. Did I miss something?
|
seems good! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
TypedPropertiesDriveronly reads classes (abstract included) and some php defined types. For interfaces, additional metadata in the form of annotations or files must be specified. This pull request makes this obsolete.