Allow installing and build on PHP 8 #1267
Conversation
sanmai
commented
Nov 12, 2020
•
sanmai
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | Fixes #1270 |
| License | MIT |
This comment has been minimized.
This comment has been minimized.
| $previousEntityLoaderState = libxml_disable_entity_loader($this->disableExternalEntities); | ||
| if (\LIBXML_VERSION < 20900) { | ||
| $previousEntityLoaderState = libxml_disable_entity_loader($this->disableExternalEntities); | ||
| } |
There was a problem hiding this comment.
as of libxml 2.9.0 entity substitution is disabled by default, so there is no need to disable the loading of external entities.
https://www.php.net/manual/en/function.libxml-disable-entity-loader.php
|
Build is green: https://travis-ci.com/github/sanmai/serializer/builds/200201670 Scrutinizer's build is borked but that's not my fault. |
|
GitHub Workflows are working: https://github.com/sanmai/serializer/pull/2/checks?check_run_id=1388349508 I think I'll be done for now. If there's anything, please ask away. |
|
@goetas sorry about pinging. Will it help to split this into parts? Say, GitHub Workflows can go in a separate PR. Travis CI can stop working at any given moment. |
|
thanks a lot! |
|
Happy to help! Would you mind punching out a new release? |
