Undefined offset: 0 when using @var null|string instead of @var string|null
#1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the property is typed with `@var string|null` everything works fine. But when it's typed in opposite order it breaks `@var null|string`: Undefined offset: 0
When `filterNullFromTypes` receives the following `[ 0 => IdentifierTypeNode("null"), 1 => IdentifierTypeNode("string") ]` types, it will map the one that is called `"null"` with `null` like this: `[ 0 => null, 1 => IdentifierTypeNode("string") ]`.
It then passes the array to `array_filter` that removes all the `null` values, leaving the following array as a result: `[1 => IdentifierTypeNode("string") ]`.
The problem is that `array_filter` keeps the keys intact, while the code that uses this doesn't expect it.
By using `array_values` we get a clean array again: `[0 => IdentifierTypeNode("string") ]`.
ruudk
changed the title
@var null|string instead of @var string|nullUndefined offset: 0 when using @var null|string instead of @var string|null
|
@goetas Thanks for the merge. Can this be tagged as the latest one is broken. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from 3.12.0 to 3.12.1 I received
Undefined offset: 0errors. After some debugging I found the problem.In the commits I explain what the problem is and how I fixed it.