Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback-method setup using XmlDriver #1310

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix callback-method setup using XmlDriver #1310

merged 1 commit into from
Jul 1, 2021

Conversation

curzio-della-santa
Copy link
Contributor

@curzio-della-santa curzio-della-santa commented Apr 8, 2021 •
edited
Loading

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1311
License MIT

@curzio-della-santa curzio-della-santa mentioned this pull request Apr 8, 2021
Closed
@goetas
Copy link
Collaborator

goetas commented Apr 8, 2021 •
edited
Loading

Hi, thanks for your pull request. Can you please rebase it and solve the merge conflicts (probably you've branched from an old branch).

Can you please also add a test for this change?

@curzio-della-santa
Copy link
Contributor Author

Rebase done, for test it must wait that I find some spare time (really busy now)

@goetas goetas merged commit 292f5db into schmittjoh:master Jul 1, 2021
@goetas
Copy link
Collaborator

goetas commented Jul 1, 2021

i think that is worth fixing it anyway

@goetas
Copy link
Collaborator

goetas commented Jul 1, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curzio-della-santa @goetas