fix iterable::class that does not exist #1315
Conversation
Tobion
commented
Apr 23, 2021
Tobion
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| foreach (self::SUPPORTED_FORMATS as $format) { | ||
| $methods[] = [ | ||
| 'direction' => GraphNavigatorInterface::DIRECTION_SERIALIZATION, | ||
| 'type' => iterable::class, |
There was a problem hiding this comment.
iterable is a psydo class and does not really exist. this is resolved as a class in the current namespace, i.e. JMS\Serializer\Handler\iterable which does not exist. this is why phpstan complained rightfully.
also the whole registration of iterable is pointless because iterables are already handled directly in the graph visitor (like for array, int etc). so to my understading, this part is irrelevant.
There was a problem hiding this comment.
makes sense, then why not put just 'iterable' as string?
There was a problem hiding this comment.
Because it wouldn't do anything? iterables are not handled via registration.
| /** | ||
| * @param mixed $data | ||
| */ | ||
| public function deserializeIterable( |
There was a problem hiding this comment.
does it mean that we do not have anymore the deserialization for iterable?
There was a problem hiding this comment.
we do. it's inside the graph visistor/navigator itself.
There was a problem hiding this comment.
see
serializer/src/GraphNavigator/DeserializationGraphNavigator.php
Lines 137 to 138 in f908d17
|
thanks! |
