Allow positional php8 attributes #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
goetas
commented
Aug 3, 2021
goetas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Doc updated | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
goetas
force-pushed
the
positional-attributes
branch
from
fee85dd to
adca7f1
Compare
goetas
force-pushed
the
positional-attributes
branch
from
adca7f1 to
6a1d242
Compare
|
@joaojacome i've implemented here the support for positional parameters for attributes, could you please have a look? |
joaojacome
reviewed
Aug 4, 2021
| if (array_key_exists('groups', $values)) { | ||
| $groups = $values['groups']; | ||
| $vars = get_defined_vars(); | ||
| /* |
There was a problem hiding this comment.
TBH I don't like to have a different behaviour depending on the annotation, but I don't see any other way :)
joaojacome
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
There are still multiple tests using the named arguments. There might be some hidden cases where the positional arguments would fail.
I'd look into running a test suite with the named arguments removed from everything (maybe using rector to rewrite them), but that may be too much of a hassle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.