Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused properties #1555

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

scyzoryck
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://github.com/schmittjoh/serializer/pull/1553/files#r1720639848
License MIT

Remove unused properties :)

@scyzoryck scyzoryck requested a review from goetas August 19, 2024 18:53
@goetas
Copy link
Collaborator

goetas commented Aug 21, 2024

Only now I have realized what you meant with your initial comment. My bad :(

Could you please rebase it? feel free to merge afterwards

@scyzoryck scyzoryck force-pushed the cleanup-union-discriminators branch from fd82cbf to 225f052 Compare August 23, 2024 20:36
@scyzoryck scyzoryck merged commit 3c18cb8 into schmittjoh:master Aug 23, 2024
18 checks passed
@scyzoryck scyzoryck deleted the cleanup-union-discriminators branch August 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants