fix detection of primitive types on union type #1575
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detect int before boolean and exclude int(1) from boolean detection fixes schmittjoh#1573
goetas
reviewed
Dec 2, 2024
| @@ -131,7 +131,7 @@ private function testPrimitive(mixed $data, string $type, string $format): bool | |||
|
|
|||
| case 'bool': | |||
| case 'boolean': | |||
| return (string) (bool) $data === (string) $data; | |||
| return (string) (bool) $data === (string) $data && 1 !== $data; // prevent false positive for 1/true | |||
There was a problem hiding this comment.
would it make sense to just use is_bool? would it break any test?
scyzoryck
reviewed
Dec 3, 2024
| @@ -475,6 +479,9 @@ public function testSerializingUnionProperties() | |||
| $serialized = $this->serialize(new UnionTypedProperties(10000)); | |||
| self::assertEquals(static::getContent('data_integer'), $serialized); | |||
|
|
|||
| $serialized = $this->serialize(new UnionTypedProperties(1)); | |||
There was a problem hiding this comment.
I'm curious what will happen with this case:
$object = new UnionTypedProperties(0);
$object = new UnionTypedProperties('');Can we add it as well? :)
There was a problem hiding this comment.
I would like to see more cases for the getSimpleUnionProperties test: note that I did extend that test with my PR.
This was referenced Dec 3, 2024
|
I have opened #1582 as well, which also touches the primitive types. |
bobvandevijver
added a commit
to utwente/living-textbook
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect int before boolean and exclude int(1) from boolean detection
fixes #1573