HHVM compatibility

[goetas]

• reflection incompatibility between hhvm & php

[schmittjoh]

Please also check the Scrutinizer issue, we might need to adjust the exception it looks like.

[stof]

tests are not green on HHVM

[stof]

allow to use symfony validator 2.2 and newer

Would be great to also allow the new Validator API available in Symfony 2.5+ (which is the only one in 3.0+)

[goetas]

@schmittjoh issues on scrutinizer errors are because HHVM introduces a new public property on the reflection object

[goetas]

@stof sorry for the mess, moved the validator feature to a separate PR #583

[goetas]

Currently making the serializer fully compatible with HHVM 3.6 is not easy.
With HHVM 3.7, tests are green.

It looks that 3.6 has a buggy implementation of the SplStack class

[schmittjoh]

@goetas, yes aware of that, but I was referring to the one about the exception. Did you check that, too?

[schmittjoh]

3.6 seems quite outdated, I think we should not try to make that compatible if it has problems.

[goetas]

@schmittjoh https://scrutinizer-ci.com/g/schmittjoh/serializer/inspections/481ad1b4-439f-4e33-88f8-0cfa960c1aab/issues/ i see only 3 new issues. can you specify ?

[goetas]

3.6 seems quite outdated, I think we should not try to make that compatible if it has problems.

totally agree. but travis allows only HHVM 3.6. I'm not aware of a way to install a different version

[schmittjoh]

I was referring to this one here: https://scrutinizer-ci.com/g/schmittjoh/serializer/inspections/f09be7fe-fd8f-4b2b-b833-45fd17ee7358/issues/files/src/JMS/Serializer/EventDispatcher/Subscriber/SymfonyValidatorSubscriber.php?status=new&orderField=path&order=asc&honorSelectedPaths=0

Maybe we need to keep the allow_failures for now and wait for an image update. It's unfortunate, but working around bugs of outdated HHVM versions sounds not so good.

[goetas]

Ok, then will keep this PR alive till travis do not update HHVM

[goetas]

blocked by facebook/hhvm#7193 (but 0d6997b#diff-e8213d9df27c4ee083659ea8fadc9423R350 is a workaround)

[stof]

this should be done only for the HHVM build rather than for PHP builds too, as the docker-based infra is faster to boot. See how it is done in Symfony

[goetas]

cool! will do

[goetas]

Finally is green! (3.7 and later)

[schmittjoh]

Great, Thanks!