add flag to not turn bonds to metals into zobs #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The API looks good to me and I've confirmed on the RDKit side that this fixes both the issues that we had previously observed. |
greglandrum
approved these changes
Aug 12, 2020
d-b-w
requested changes
Aug 18, 2020
| // Load a molecule with a single bond to a metal. Make sure that disabling the automatic conversion | ||
| // to zob behaves as expected | ||
|
|
||
| const std::string testfile = (test_samples_path / "metalZobs.mae").string(); |
There was a problem hiding this comment.
I think that the tests are failing because this is metalZobs.mae and the test file name is metalZob.mae (extra s here).
There was a problem hiding this comment.
thanks! I fixed that and made the test more precise. Seems like the tests are passing now
|
I've merged this PR |
d-b-w
added a commit
that referenced
this pull request
Oct 13, 2020
For use in Schrödinger release 2020-4. Set version in CMakelists to 1.4.2. There are no backwards incompatible API changes in this release. There is a class that is now exported, and there are a couple of methods that are now const. Features include: * add flag to not turn bonds to metals into zobs Pull #77 * some minor performance improvements Pull #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added flag to not turn single and double bonds to metals into zobs.
added automated test to show the length of the bond is around the same as a single bond (zobs to metals usually are stretched out)